#492: Use Maven dependency cache in CI workflows - #2412
Open
krystynaShatkovska wants to merge 4 commits into
Open
krystynaShatkovska wants to merge 4 commits into
krystynaShatkovska wants to merge 4 commits into
Conversation
Collaborator
Coverage Report for CI Build 35583719736Warning No base build found for commit Coverage: 74.238%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
laert-ll
suggested changes
Sep 7, 2026
Contributor
There was a problem hiding this comment.
Thanks for your work!
I think additionally, you should also add the cache to graalvm/setup-graalvm@v1 as well in .github/workflows/nightly-build.yml and .github/workflows/release.yml. Other than that, it looks good to me. Remember to link the issue in the description and to label it as internal.
The build-natives jobs in nightly-build.yml and release.yml also build with Maven after checking out the repository, so give the graalvm/setup-graalvm@v1 step the same maven dependency cache that was already added to the setup-java steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #492
Implemented changes:
Added cache: 'maven' to the setup-java@v5 step in build.yml, build-pr.yml, mutation-test.yml, and the deploy job of nightly-build.yml, so these jobs restore a shared ~/.m2/repository dependency cache instead of re-downloading all Maven dependencies on every run. This matches the convention already used in release.yml, update-cve.yml, and update-urls.yml.
The cache is keyed on the hash of the pom.xml files (handled automatically by setup-java), so it is reused while dependencies are unchanged and only re-created when they change
Testing instructions
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc